GH-45048: [C++][Parquet] Deprecate unused chunk_size parameter in parquet::arrow::FileWriter::NewRowGroup()
#45049
+18
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Parquet
Component: C++
awaiting committer review
kszucs
changed the title
chunk_size parameter in parquet::arrow::FileWriter::NewRowGroup()chunk_size parameter in parquet::arrow::FileWriter::NewRowGroup()
|
|
kszucs
force-pushed
the
parquet-new-row-group
branch
2 times, most recently
from
81c50e0 to
9234e16
Compare
github-actions
bot
added
awaiting changes
kszucs
force-pushed
the
parquet-new-row-group
branch
from
f287bc8 to
49bb54a
Compare
github-actions
bot
added
awaiting change review
kou
reviewed
Dec 17, 2024
| @@ -590,7 +590,7 @@ gparquet_arrow_file_writer_new_row_group(GParquetArrowFileWriter *writer, | |||
| { | |||
| auto parquet_arrow_file_writer = gparquet_arrow_file_writer_get_raw(writer); | |||
| return garrow::check(error, | |||
| parquet_arrow_file_writer->NewRowGroup(chunk_size), | |||
| parquet_arrow_file_writer->NewRowGroup(), | |||
There was a problem hiding this comment.
Could you also remove the chunk_size parameter from this function?
There was a problem hiding this comment.
Sure, do I need to deprecate it?
There was a problem hiding this comment.
You don't need to deprecate it. We can do it as a breaking change. Because this will not be used by many users. This is a method added in 18.0.0.
diff --git a/c_glib/parquet-glib/arrow-file-writer.cpp b/c_glib/parquet-glib/arrow-file-writer.cpp
index 2b8e2bdeac..82f86e823b 100644
--- a/c_glib/parquet-glib/arrow-file-writer.cpp
+++ b/c_glib/parquet-glib/arrow-file-writer.cpp
@@ -574,7 +574,6 @@ gparquet_arrow_file_writer_write_table(GParquetArrowFileWriter *writer,
/**
* gparquet_arrow_file_writer_new_row_group:
* @writer: A #GParquetArrowFileWriter.
- * @chunk_size: The max number of rows in a row group.
* @error: (nullable): Return location for a #GError or %NULL.
*
* Start a new row group.
@@ -585,7 +584,6 @@ gparquet_arrow_file_writer_write_table(GParquetArrowFileWriter *writer,
*/
gboolean
gparquet_arrow_file_writer_new_row_group(GParquetArrowFileWriter *writer,
- gsize chunk_size,
GError **error)
{
auto parquet_arrow_file_writer = gparquet_arrow_file_writer_get_raw(writer);
diff --git a/c_glib/parquet-glib/arrow-file-writer.h b/c_glib/parquet-glib/arrow-file-writer.h
index 2c82f7c1f8..b35cea1182 100644
--- a/c_glib/parquet-glib/arrow-file-writer.h
+++ b/c_glib/parquet-glib/arrow-file-writer.h
@@ -136,7 +136,6 @@ gparquet_arrow_file_writer_write_table(GParquetArrowFileWriter *writer,
GPARQUET_AVAILABLE_IN_18_0
gboolean
gparquet_arrow_file_writer_new_row_group(GParquetArrowFileWriter *writer,
- gsize chunk_size,
GError **error);
GPARQUET_AVAILABLE_IN_18_0There was a problem hiding this comment.
Could you also update c_glib/parquet-glib/arrow-file-writer.h?
BTW, could you use your fork not apache/arrow next time?
There was a problem hiding this comment.
Ohh, sorry. That was accidental.
There was a problem hiding this comment.
Created a new PR from my fork #45088
Closing this and removing the branch.
github-actions
bot
added
awaiting changes
wgtmac
reviewed
Dec 18, 2024
| @@ -556,7 +556,7 @@ cdef extern from "parquet/arrow/writer.h" namespace "parquet::arrow" nogil: | |||
| const shared_ptr[ArrowWriterProperties]& arrow_properties) | |||
|
|
|||
| CStatus WriteTable(const CTable& table, int64_t chunk_size) | |||
| CStatus NewRowGroup(int64_t chunk_size) | |||
| CStatus NewRowGroup() | |||
There was a problem hiding this comment.
I can expose the deprecated method as well.
github-actions
bot
added
awaiting change review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Just noticed that the implementation doesn't use the parameter.
What changes are included in this PR?
Remove the parameter from
AddRowGroup()Are these changes tested?
Are there any user-facing changes?
The
chunk_sizeparameter is now deprecated.chunk_sizeparameter inparquet::arrow::FileWriter::NewRowGroup()#45048